Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/14079#discussion_r86600439
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -306,12 +323,24 @@ private[spark] class TaskSchedulerImpl(
}
}
+ // Before making any offers, remove any nodes from the blacklist whose
blacklist has expired. Do
+ // this here to avoid a separate thread and added synchronization
overhead, and also because
+ // updating the blacklist is only relevant when task offers are being
made.
+ blacklistTracker.foreach(_.applyBlacklistTimeout())
+
+ val sortedTaskSets = rootPool.getSortedTaskSetQueue
--- End diff --
why'd this move? (it's a little confusing up here since it's not used until
later)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
