Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14079#discussion_r86649370
  
    --- Diff: 
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
 ---
    @@ -121,13 +121,20 @@ private[spark] abstract class YarnSchedulerBackend(
         }
       }
     
    +  private[cluster] def prepareRequestExecutors(requestedTotal: Int): 
RequestExecutors = {
    --- End diff --
    
    do you need a new method for this? (can it just be part of 
doRequestTotalExecutors?) (See comment in test)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to