Github user vijoshi commented on a diff in the pull request:
https://github.com/apache/spark/pull/15742#discussion_r86662740
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala ---
@@ -275,6 +277,79 @@ class HistoryServerSuite extends SparkFunSuite with
BeforeAndAfter with Matchers
all (siteRelativeLinks) should startWith (uiRoot)
}
+ test("ajax rendered relative links are prefixed with uiRoot
(spark.ui.proxyBase)") {
+
+ val proxyBaseBeforeTest = System.getProperty("spark.ui.proxyBase")
+ val uiRoot = "/testwebproxybase"
+ System.setProperty("spark.ui.proxyBase", uiRoot)
--- End diff --
I do need to use system properties as that's how this particular property
seems to work. The test suite `HistoryServerSuite` already uses
`ResetSystemProperties`, so I have fixed the tests to not try to store/reset
system properties on their own.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
