Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15659#discussion_r86674922
--- Diff: python/setup.py ---
@@ -0,0 +1,180 @@
+#!/usr/bin/env python
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+from __future__ import print_function
+import glob
+import os
+import sys
+from setuptools import setup, find_packages
+from shutil import copyfile, copytree, rmtree
+
+if sys.version_info < (2, 7):
+ print("Python versions prior to 2.7 are not supported for pip
installed PySpark.",
+ file=sys.stderr)
+ exit(-1)
+
+try:
+ exec(open('pyspark/version.py').read())
+except IOError:
+ print("Failed to load PySpark version file for packaging you must be
in Spark's python dir.",
+ file=sys.stderr)
+ sys.exit(-1)
+VERSION = __version__
+# A temporary path so we can access above the Python project root and
fetch scripts and jars we need
+TEMP_PATH = "deps"
+SPARK_HOME = os.path.abspath("../")
+JARS_PATH = "%s/assembly/target/scala-2.11/jars/" % SPARK_HOME
+
+# Use the release jars path if we are in release mode.
+if (os.path.isfile("../RELEASE") and
len(glob.glob("../jars/spark*core*.jar")) == 1):
+ JARS_PATH = "%s/jars/" % SPARK_HOME
+
+EXAMPLES_PATH = "%s/examples/src/main/python" % SPARK_HOME
+SCRIPTS_PATH = "%s/bin" % SPARK_HOME
+SCRIPTS_TARGET = "%s/bin" % TEMP_PATH
+JARS_TARGET = "%s/jars" % TEMP_PATH
+EXAMPLES_TARGET = "%s/examples" % TEMP_PATH
+
+# Check and see if we are under the spark path in which case we need to
build the symlink farm.
+# This is important because we only want to build the symlink farm while
under Spark otherwise we
+# want to use the symlink farm. And if the symlink farm exists under while
under Spark (e.g. a
+# partially built sdist) we should error and have the user sort it out.
+in_spark =
(os.path.isfile("../core/src/main/scala/org/apache/spark/SparkContext.scala") or
+ (os.path.isfile("../RELEASE") and
len(glob.glob("../jars/spark*core*.jar")) == 1))
+
+if (in_spark):
+ # Construct links for setup
+ try:
+ os.mkdir(TEMP_PATH)
+ except:
+ print("Temp path for symlink to parent already exists %s" %
TEMP_PATH, file=sys.stderr)
+ exit(-1)
+
+try:
+ if (in_spark):
+ # Construct the symlink farm - this is necessary since we can't
refer to the path above the
+ # package root and we need to copy the jars and scripts which are
up above the python root.
+ if getattr(os, "symlink", None) is not None:
+ os.symlink(JARS_PATH, JARS_TARGET)
+ os.symlink(SCRIPTS_PATH, SCRIPTS_TARGET)
+ os.symlink(EXAMPLES_PATH, EXAMPLES_TARGET)
+ else:
+ # For windows fall back to the slower copytree
+ copytree(JARS_PATH, JARS_TARGET)
+ copytree(SCRIPTS_PATH, SCRIPTS_TARGET)
+ copytree(EXAMPLES_PATH, EXAMPLES_TARGET)
+ else:
+ # If we are not inside of SPARK_HOME verify we have the required
symlink farm
+ if not os.path.exists(JARS_TARGET):
+ print("To build packaging must be in the python directory
under the SPARK_HOME.",
+ file=sys.stderr)
+ # We copy the shell script to be under pyspark/python/pyspark so
that the launcher scripts
+ # find it where expected. The rest of the files aren't copied
because they are accessed
+ # using Python imports instead which will be resolved correctly.
+ try:
+ os.makedirs("pyspark/python/pyspark")
+ except OSError:
+ # Don't worry if the directory already exists.
+ True
+ copyfile("pyspark/shell.py", "pyspark/python/pyspark/shell.py")
+
+ if not os.path.isdir(SCRIPTS_TARGET):
+ print("You must first create a source dist and install that source
dist.", file=sys.stderr)
+ exit(-1)
+
+ # Scripts directive requires a list of each script path and does not
take wild cards.
+ script_names = os.listdir(SCRIPTS_TARGET)
+ scripts = list(map(lambda script: os.path.join(SCRIPTS_TARGET,
script), script_names))
+ # We add find_spark_home.py to the bin directory we install so that
pip installed PySpark
+ # will search for SPARK_HOME with Python.
+ scripts.append("pyspark/find_spark_home.py")
+
+ # Parse the README markdown file into rst for PyPI
+ long_description = "!!!!! missing pandoc do not upload to PyPI !!!!"
+ try:
+ import pypandoc
+ long_description = pypandoc.convert('README.md', 'rst')
+ except ImportError:
+ print("Could not import pypandoc - required to package PySpark",
file=sys.stderr)
--- End diff --
Maybe? You can still build a perfectly installable pip package but the
long_description won't be fully present. Generally most setup scripts seem to
print an error message but continue on - but I'm open to hard exiting if we
think that would be better (depends on if we expect users to build their own
pip install packages from source or not).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
