Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15767#discussion_r86676501
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala
---
@@ -232,7 +232,9 @@ private[csv] object CSVTypeCast {
nullable: Boolean = true,
options: CSVOptions = CSVOptions()): Any = {
- if (nullable && datum == options.nullValue) {
+ // datum can be null if the number of fields found is less than the
length of the schema
+ if (datum == options.nullValue || datum == null) {
+ require(nullable, "null value found but the field is not nullable.")
--- End diff --
Oh, I thought users set a non-nullable field in the schema inappropriate
for data having null values and that is an illigal argument.. FWIW,
`IllegalArgumentException` seems extending `RuntimeException` too..
Let me revert it back. I don't feel strongly about this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
