Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15546#discussion_r86679323
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
 ---
    @@ -45,7 +45,7 @@ class LogicalPlanToSQLSuite extends SQLBuilderTest with 
SQLTestUtils {
     
       // Used for generating new query answer files by saving
       private val regenerateGoldenFiles: Boolean = 
System.getenv("SPARK_GENERATE_GOLDEN_FILES") == "1"
    -  private val goldenSQLPath = getTestResourcePath("sqlgen")
    +  private val goldenSQLPath = "src/test/resources/sqlgen/"
    --- End diff --
    
    This is a bug fix. It is not related to this PR. Could you create a 
separate one? Make it consistent with what we did in `SQLQueryTestSuite`? 
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to