Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/15546
  
    @dongjoon-hyun I have a general comment about the SQL generation fixes. Not 
sure how you fix the issue. Normally, when we did it, we need to see the 
analyzed SQL plan. In this case, it becomes a little complex, we called 
`addSubqueryIfNeeded` in `toSQL`. 
    
    Could you try to show reviewers the failed plans with the added 
`SubqueryAlias`? Then, we can discuss whether the fix coverage and test case 
coverage. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to