GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/15789
[SPARK-18292][SQL] LogicalPlanToSQLSuite should not use resource dependent
path for golden file generation
## What changes were proposed in this pull request?
`LogicalPlanToSQLSuite` uses the following command to update the existing
answer files.
```bash
SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "hive/test-only
*LogicalPlanToSQLSuite"
```
However, after introducing `getTestResourcePath`, it fails to update the
previous golden answer files in the predefined directory. This issue aims to
fix that by recovering the original path.
```scala
- private val goldenSQLPath = getTestResourcePath("sqlgen")
+ private val goldenSQLPath = "src/test/resources/sqlgen/"
```
## How was this patch tested?
It's a testsuite update. Manual.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongjoon-hyun/spark SPARK-18292
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/15789.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15789
----
commit 725cd454fb44e19f773934724420bb01adf98a28
Author: Dongjoon Hyun <dongj...@apache.org>
Date: 2016-11-06T07:59:49Z
[SPARK-18292][SQL] LogicalPlanToSQLSuite should not use resource dependent
path for golden file generation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
