Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/15484#discussion_r86688650 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -216,10 +216,16 @@ class Analyzer( * Group Count: N + 1 (N is the number of group expressions) * * We need to get all of its subsets for the rule described above, the subset is - * represented as the bit masks. + * represented as sequence of expressions. */ - def bitmasks(r: Rollup): Seq[Int] = { - Seq.tabulate(r.groupByExprs.length + 1)(idx => (1 << idx) - 1) + def rollupExprs(exprs: Seq[Expression]): Seq[Seq[Expression]] = { + val buffer = ArrayBuffer.empty[Seq[Expression]] --- End diff -- `exprs.inits` is much more concise.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org