Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/15652#discussion_r86689337
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -308,14 +308,22 @@ private[spark] object JettyUtils extends Logging {
sslOptions.createJettySslContextFactory().foreach { factory =>
// If the new port wraps around, do not try a privileged port.
+
+ require(sslOptions.port == 0 || (1024 <= sslOptions.port &&
sslOptions.port < 65536))
+
val securePort =
if (currentPort != 0) {
- (currentPort + 400 - 1024) % (65536 - 1024) + 1024
+ if (1024 < sslOptions.port && sslOptions.port < 65536) {
+ sslOptions.port
+ } else {
+ (currentPort + 400 - 1024) % (65536 - 1024) + 1024
--- End diff --
Can you add a comment in the code explaining the math done here ? It will
help readability of the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
