Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15764#discussion_r86689510
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -923,6 +923,24 @@ class SessionCatalog(
}
}
+ /**
+ * Returns whether it is a temporary function. If not existed, returns
false.
+ */
+ def isTemporaryFunction(name: FunctionIdentifier): Boolean = {
+ // copied from HiveSessionCatalog
+ val hiveFunctions = Seq(
+ "hash",
+ "histogram_numeric",
+ "percentile")
+
+ // A temporary function is a function that has been registered in
functionRegistry
+ // without a database name, and is neither a built-in function nor a
Hive function
+ name.database.isEmpty &&
+ functionRegistry.functionExists(name.funcName) &&
+ !FunctionRegistry.builtin.functionExists(name.funcName) &&
--- End diff --
Our built-in function registry is using `SimpleFunctionRegistry`, which is
using [case insensitive string key hash
map](https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala#L71-L72).
Thus, no need to add `toLowerCase`. However, we need to add a test case to
ensure we can capture the potential change in this part.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
