Github user witgo commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15505#discussion_r86777769
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
    @@ -486,7 +481,7 @@ private[spark] class Executor(
        * Download any missing dependencies if we receive a new set of files 
and JARs from the
        * SparkContext. Also adds any new JARs we fetched to the class loader.
        */
    -  private def updateDependencies(newFiles: HashMap[String, Long], newJars: 
HashMap[String, Long]) {
    +  private def updateDependencies(newFiles: Map[String, Long], newJars: 
Map[String, Long]) {
    --- End diff --
    
    @wzhfy 
    The source of this parameter is `sc.addedFiles` and `sc.addedJars`, Their 
types are `mutable.Map[String, Long]` , This change is reasonable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to