Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15797#discussion_r86866556
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -355,25 +355,30 @@ class InMemoryCatalog(
}
}
- val tableDir = new Path(catalog(db).db.locationUri, table)
- val partitionColumnNames = getTable(db, table).partitionColumnNames
+ val tableMeta = getTable(db, table)
+ val partitionColumnNames = tableMeta.partitionColumnNames
+ val tableLocation = new Path(tableMeta.storage.locationUri.get)
// TODO: we should follow hive to roll back if one partition path
failed to create.
parts.foreach { p =>
- // If location is set, the partition is using an external partition
location and we don't
- // need to handle its directory.
- if (p.storage.locationUri.isEmpty) {
- val partitionPath = partitionColumnNames.flatMap { col =>
- p.spec.get(col).map(col + "=" + _)
- }.mkString("/")
- try {
- val fs = tableDir.getFileSystem(hadoopConfig)
- fs.mkdirs(new Path(tableDir, partitionPath))
- } catch {
- case e: IOException =>
- throw new SparkException(s"Unable to create partition path
$partitionPath", e)
+ val partitionLocation = p.storage.locationUri.getOrElse {
+ val partitionPath = partitionColumnNames.map(col => col + "=" +
p.spec(col)).mkString("/")
--- End diff --
Do we need to escape these, as in `PartitioningUtils.escapePathName`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
