Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15806#discussion_r86991593
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala
 ---
    @@ -219,10 +219,11 @@ class StreamingQueryManager private[sql] 
(sparkSession: SparkSession) {
           }
     
           // If offsets have already been created, we trying to resume a query.
    -      if (!recoverFromCheckpointLocation) {
    +      if (recoverFromCheckpointLocation) {
    --- End diff --
    
    If I correctly interpret [this 
comment](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala#L181-L183),
 an exception will be thrown when `recoverFromCheckpointLocation` == `false` 
and `fs.exists(checkpointPath)` == `true` are satisfied.
    Is [the 
comment](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala#L181-L183)
 wrong if this line is correct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to