Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15779#discussion_r87014522
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -404,6 +406,13 @@ object LinearRegression extends
DefaultParamsReadable[LinearRegression] {
@Since("1.6.0")
override def load(path: String): LinearRegression = super.load(path)
+
+ /**
+ * When using [[LinearRegression.solver]] == "normal", the solver must
limit the number of
+ * features to at most this number.
--- End diff --
minor suggestion: perhaps an explanation as to why might be useful. "must
limit the number of features to at most this number, because the entire
covariance matrix `X^T^X` will be collected on the driver. This limit helps
prevent memory overflow errors.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
