Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15807
`subexpr2` is a special case as it is an `AssertNotNull` which is a
`NonSQLExpression` and can throw an exception at runtime. If I understand
correctly, a SQL expression should not throw an exception like that. Running
subexpressions for pure SQL expressions should be a performance issue, I guess.
I would a bit prefer to disallow subexpression elimination for a
`NonSQLExpression`. Looks like it is easy to cause not excepted result and
exception.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
