Github user ericl commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15814#discussion_r87129853
  
    --- Diff: 
core/src/main/scala/org/apache/spark/internal/io/FileCommitProtocol.scala ---
    @@ -86,6 +86,16 @@ abstract class FileCommitProtocol {
       def newTaskTempFile(taskContext: TaskAttemptContext, dir: 
Option[String], ext: String): String
     
       /**
    +   * Similar to newTaskTempFile(), but allows files to committed to an 
absolute output location.
    +   * Depending on the implementation, there may be weaker guarantees 
around adding files this way.
    +   */
    +  def newTaskTempFileAbsPath(
    --- End diff --
    
    I thought about combining it but I think the method semantics become too 
subtle then.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to