GitHub user lw-lin opened a pull request:

    https://github.com/apache/spark/pull/15828

    [WIP][SS] CompactibleFileStreamLog should not rely on "compactInterval" to 
detect a compaction batch

    ## What changes were proposed in this pull request?
    
    Right now CompactibleFileStreamLog uses compactInterval to check if a batch 
is a compaction batch. However, since this conf is controlled by the user, they 
may just change it, and CompactibleFileStreamLog will just silently return the 
wrong answer.
    
    ## How was this patch tested?
    
    (Please explain how this patch was tested. E.g. unit tests, integration 
tests, manual tests)
    (If this patch involves UI changes, please attach a screenshot; otherwise, 
remove this)
    
    Please review 
https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark before 
opening a pull request.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lw-lin/spark test-compact-1109-

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/15828.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15828
    
----
commit 72de68d070bfc55e6d59517c3b66a572159b34c6
Author: Liwei Lin <lwl...@gmail.com>
Date:   2016-11-07T08:33:01Z

    Compact

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to