Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r86424146
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ---
@@ -99,5 +102,182 @@ case class GenerateExec(
}
}
}
-}
+ override def inputRDDs(): Seq[RDD[InternalRow]] = {
+ child.asInstanceOf[CodegenSupport].inputRDDs()
+ }
+
+ protected override def doProduce(ctx: CodegenContext): String = {
+ // We need to add some code here for terminating generators.
+ child.asInstanceOf[CodegenSupport].produce(ctx, this)
+ }
+
+ override def doConsume(ctx: CodegenContext, input: Seq[ExprCode], row:
ExprCode): String = {
+ ctx.currentVars = input
+ ctx.copyResult = true
+
+ // Add input rows to the values when we are joining
+ val values = if (join) {
+ input
+ } else {
+ Seq.empty
+ }
+
+ // Generate the driving expression.
+ val data = boundGenerator.genCode(ctx)
--- End diff --
Will moving this into codeGenCollection/codeGenTraversableOnce be better?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
