Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15814#discussion_r87315912
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala
 ---
    @@ -104,4 +113,42 @@ case class InsertIntoHadoopFsRelationCommand(
     
         Seq.empty[Row]
       }
    +
    +  /**
    +   * Deletes all partition files that match the specified static prefix. 
Partitions with custom
    +   * locations are also cleared based on the custom locations map given to 
this class.
    +   */
    +  private def deleteMatchingPartitions(fs: FileSystem, 
qualifiedOutputPath: Path): Unit = {
    +    val staticPartitionPrefix = if (staticPartitionKeys.nonEmpty) {
    +      "/" + partitionColumns.flatMap { p =>
    +        staticPartitionKeys.get(p.name) match {
    +          case Some(value) =>
    +            Some(
    +              PartitioningUtils.escapePathName(p.name) + "=" +
    +              PartitioningUtils.escapePathName(value))
    +          case None =>
    +            None
    +        }
    +      }.mkString("/")
    +    } else {
    +      ""
    +    }
    +    // first clear the path determined by the static partition keys (e.g. 
/table/foo=1)
    +    val staticPrefixPath = 
qualifiedOutputPath.suffix(staticPartitionPrefix)
    +    if (fs.exists(staticPrefixPath) && !fs.delete(staticPrefixPath, true 
/* recursively */)) {
    --- End diff --
    
    OK for me if we document it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to