Github user darabos commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2081#discussion_r16948878
  
    --- Diff: ec2/spark_ec2.py ---
    @@ -342,6 +343,15 @@ def launch_cluster(conn, opts, cluster_name):
             device.delete_on_termination = True
             block_map["/dev/sdv"] = device
     
    +    # AWS ignores the AMI-specified block device mapping for M3.
    +    if opts.instance_type.startswith('m3.'):
    +        for i in range(get_num_disks(opts.instance_type)):
    +            dev = BlockDeviceType()
    +            dev.ephemeral_name = 'ephemeral{}'.format(i)
    --- End diff --
    
    > This format syntax won't work in Python 2.6 unfortunately; use 
"ephemeral%d" % i
    
    Done.
    
    The script has a good number of `.format()` string interpolations though. 
Does it really support Python 2.6?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to