Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15865#discussion_r87711600
--- Diff:
sql/catalyst/src/test/java/org/apache/spark/sql/catalyst/expressions/HiveHasherSuite.java
---
@@ -28,7 +28,7 @@
import java.util.Set;
public class HiveHasherSuite {
- private final static HiveHasher hasher = new HiveHasher();
+ private final HiveHasher hasher = new HiveHasher();
--- End diff --
You made this non-static; that's not a style issue right? it may be OK but
some of these changes don't seem to match the description
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
