Github user koeninger commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15849#discussion_r87795091
  
    --- Diff: 
examples/src/main/java/org/apache/spark/examples/sql/streaming/JavaStructuredKafkaWordCount.java
 ---
    @@ -0,0 +1,96 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.examples.sql.streaming;
    +
    +import org.apache.spark.api.java.function.FlatMapFunction;
    +import org.apache.spark.sql.Dataset;
    +import org.apache.spark.sql.Encoders;
    +import org.apache.spark.sql.Row;
    +import org.apache.spark.sql.SparkSession;
    +import org.apache.spark.sql.streaming.StreamingQuery;
    +
    +import java.util.Arrays;
    +import java.util.Iterator;
    +
    +/**
    + * Consumes messages from one or more topics in Kafka and does wordcount.
    + * Usage: JavaStructuredKafkaWordCount <bootstrap-servers> 
<subscribe-type> <topics>
    + *   <bootstrap-servers> The Kafka "bootstrap.servers" configuration. A
    + *   comma-separated list of host:port.
    + *   <subscribe-type> There are three kinds of type, i.e. 'assign', 
'subscribe',
    + *   'subscribePattern'.
    + *   |- <assign> Specific TopicPartitions to consume. Json string
    + *   |  {"topicA":[0,1],"topicB":[2,4]}.
    + *   |- <subscribe> The topic list to subscribe. A comma-separated list of
    + *   |  topics.
    + *   |- <subscribePattern> The pattern used to subscribe to topic(s).
    + *   |  Only one of "assign, "subscribe" or "subscribePattern" options can 
be
    + *   |  specified for Kafka source.
    + *   <topics> A list of one or more kafka topics to consume from. Please 
refer
    --- End diff --
    
    This isn't really a list of topics for assign or subscribePattern. I'd say 
use a more general description, or stick to just subscribe


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to