Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15883#discussion_r87827463
--- Diff: R/pkg/R/mllib.R ---
@@ -936,20 +939,23 @@ setMethod("predict", signature(object =
"MultilayerPerceptronClassificationModel
# Returns the summary of a Multilayer Perceptron Classification Model
produced by \code{spark.mlp}
#' @param object a Multilayer Perceptron Classification Model fitted by
\code{spark.mlp}
-#' @return \code{summary} returns a list containing \code{labelCount},
\code{layers}, and
-#' \code{weights}. For \code{weights}, it is a numeric vector with
length equal to
-#' the expected given the architecture (i.e., for 8-10-2 network,
100 connection weights).
+#' @return \code{summary} returns a list containing \code{numOfInputs},
\code{numOfOutputs},
+#' \code{layers}, and \code{weights}. For \code{weights}, it is a
numeric vector with
+#' length equal to the expected given the architecture (i.e., for
8-10-2 network,
+#' 100 connection weights).
#' @rdname spark.mlp
#' @export
#' @aliases summary,MultilayerPerceptronClassificationModel-method
#' @note summary(MultilayerPerceptronClassificationModel) since 2.1.0
setMethod("summary", signature(object =
"MultilayerPerceptronClassificationModel"),
function(object) {
jobj <- object@jobj
- labelCount <- callJMethod(jobj, "labelCount")
layers <- unlist(callJMethod(jobj, "layers"))
+ numOfInputs <- head(layers, n = 1)
+ numOfOutputs <- tail(layers, n = 1)
weights <- callJMethod(jobj, "weights")
- list(labelCount = labelCount, layers = layers, weights =
weights)
+ list(numOfInputs = numOfInputs, numOfOutputs = numOfOutputs,
--- End diff --
I changed the summary output to ```numOfInputs``` and ```numOfOutputs```,
which is consistent with ```mlp``` in R ```RSNNS``` package. The original
```labelCount``` is actually the ```numOfOutputs```, but the later one should
be more descriptive as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
