Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/14720#discussion_r87908473
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -856,6 +856,17 @@ class HiveQuerySuite extends HiveComparisonTest with
BeforeAndAfter {
sql("DROP TABLE alter1")
}
+ test("SPARK-12868 ADD JAR FROM HDFS") {
+ val testJar = "hdfs://nn:8020/foo.jar"
+ // This should fail with unknown host, as its just testing the URL
parsing
+ // before SPARK-12868 it was failing with Malformed URI
+ val e = intercept[RuntimeException] {
--- End diff --
I think this test should be improved before merging this. Looking for a
RuntimeException to validate that the Jar was registered is brittle and can
easily pass when the registration doesn't actually work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
