Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r88007064 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ComplexTypeSuite.scala --- @@ -118,19 +118,20 @@ class ComplexTypeSuite extends SparkFunSuite with ExpressionEvalHelper { } test("CreateArray") { - val intSeq = Seq(5, 10, 15, 20, 25) - val longSeq = intSeq.map(_.toLong) - val strSeq = intSeq.map(_.toString) - checkEvaluation(CreateArray(intSeq.map(Literal(_))), intSeq, EmptyRow) - checkEvaluation(CreateArray(longSeq.map(Literal(_))), longSeq, EmptyRow) - checkEvaluation(CreateArray(strSeq.map(Literal(_))), strSeq, EmptyRow) - - val intWithNull = intSeq.map(Literal(_)) :+ Literal.create(null, IntegerType) - val longWithNull = longSeq.map(Literal(_)) :+ Literal.create(null, LongType) - val strWithNull = strSeq.map(Literal(_)) :+ Literal.create(null, StringType) - checkEvaluation(CreateArray(intWithNull), intSeq :+ null, EmptyRow) - checkEvaluation(CreateArray(longWithNull), longSeq :+ null, EmptyRow) - checkEvaluation(CreateArray(strWithNull), strSeq :+ null, EmptyRow) + // Array is required to pass Array(_, containsNull = false) as type information --- End diff -- You are right. I fixed the comment. It still matters it is `Array`.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org