Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15880#discussion_r88032830
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -448,7 +448,7 @@ class JsonSuite extends QueryTest with SharedSQLContext
with TestJsonData {
// Number and String conflict: resolve the type as number in this
query.
checkAnswer(
- sql("select num_str + 1.2 from jsonTable where num_str > 14"),
+ sql("select num_str + 1.2 from jsonTable where num_str > 14d"),
--- End diff --
now we have a compatibility issue here: when comparing string of large
numbers(larger than long) with int, we cast that string to int, which will
return null(because it's not castable) and the filter condition becomes false.
Is it a valid use case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
