GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/15901
[SPARK-18467][SQL] Refactor StaticInvoke, Invoke and NewInstance.
## What changes were proposed in this pull request?
Refactor `StaticInvoke`, `Invoke` and `NewInstance` as:
- Introduce `InvokeLike` to extract common logic from `StaticInvoke`,
`Invoke` and `NewInstance` to prepare arguments.
- Remove unneeded null checking and fix nullability of `NewInstance`.
- Modify to short circuit if arguments have `null` when `propageteNull ==
true`.
## How was this patch tested?
Existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ueshin/apache-spark issues/SPARK-18467
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/15901.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15901
----
commit 9bf9aa9d3f376e65132fb3551805ce59958f73c0
Author: Takuya UESHIN <ues...@happy-camper.st>
Date: 2016-11-15T09:18:44Z
Introduce `InvokeLike` to extract common logic from `StaticInvoke`,
`Invoke` and `NewInstance`.
commit 28f6200f2911cfe757a538b0ef633659a5f9c52f
Author: Takuya UESHIN <ues...@happy-camper.st>
Date: 2016-11-15T09:46:30Z
Refactor to remove unneeded null checking and fix nullability of
`NewInstance`.
commit 2f30f53cf3c9244ba2171a9300e2427bf50e4d7f
Author: Takuya UESHIN <ues...@happy-camper.st>
Date: 2016-11-16T03:42:42Z
Modify to short circuit if arguments have null when propageteNull == true.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
