Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15915#discussion_r88453146
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -331,7 +331,12 @@ private[spark] class MemoryStore(
var unrollMemoryUsedByThisBlock = 0L
// Underlying buffer for unrolling the block
val redirectableStream = new RedirectableOutputStream
- val bbos = new
ChunkedByteBufferOutputStream(initialMemoryThreshold.toInt, allocator)
+ val chunkSize = if (initialMemoryThreshold >= Integer.MAX_VALUE) {
--- End diff --
Yes, this is no worse than the current behavior (error) in this case; is
this valid? It looks like it's valid to use something smaller than this init
threshold if it's huge. Tests will help prove that out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
