Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r88593822
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -603,7 +603,14 @@ case class ExternalMapToCatalyst private(
override def foldable: Boolean = false
- override def dataType: MapType = MapType(keyConverter.dataType,
valueConverter.dataType)
+ override def dataType: MapType = {
+ val isPrimitiveType = valueType match {
+ case BooleanType | ByteType | ShortType | IntegerType | LongType |
+ FloatType | DoubleType => true
+ case _ => false
+ }
+ MapType(keyConverter.dataType, valueConverter.dataType,
!isPrimitiveType)
--- End diff --
it should be false, do we return true now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
