Github user srowen commented on the issue: https://github.com/apache/spark/pull/15925 Yes you're exactly right, what I meant was that if "IN (empty set)" is never generated in SQL, then there's no problem with how it's generated. I suppose it would still also be correct to make sure the the SQL generation code does generate "IN ('')" or whatever is correct for some/all dialects just in case this ever comes up again.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org