Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15777#discussion_r88778015
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/clustering/BisectingKMeans.scala ---
@@ -95,8 +95,7 @@ class BisectingKMeansModel private[ml] (
@Since("2.0.0")
override def copy(extra: ParamMap): BisectingKMeansModel = {
val copied = copyValues(new BisectingKMeansModel(uid, parentModel),
extra)
- if (trainingSummary.isDefined) copied.setSummary(trainingSummary.get)
- copied.setParent(this.parent)
+ copied.setSummary(trainingSummary).setParent(this.parent)
--- End diff --
This looks better. Could you make the change for Scala LiR, LoR, GLM and
KMeans as well? I think they should be consistent. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
