Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15956#discussion_r88845470
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -388,6 +388,21 @@ abstract class BinaryComparison extends BinaryOperator
with Predicate {
defineCodeGen(ctx, ev, (c1, c2) => s"${ctx.genComp(left.dataType,
c1, c2)} $symbol 0")
}
}
+
+ override def inputType: AbstractDataType = AnyDataType
--- End diff --
We need this to satisfy `BinaryOperator`, the type checking logic is
defined by both `BinaryOperator` and `checkInputDataTypes` here. Shall we make
`BinaryComparison` not extends `BinaryOperator` and duplicate its type checking
logic here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
