Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15956#discussion_r88964664 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -388,6 +388,26 @@ abstract class BinaryComparison extends BinaryOperator with Predicate { defineCodeGen(ctx, ev, (c1, c2) => s"${ctx.genComp(left.dataType, c1, c2)} $symbol 0") } } + + // The type checking logic of BinaryComparison can't be expressed by `inputType`, so we use + // AnyDataType here to bypass this check, and implement the actual type checking logic in + // `checkInputDataTypes` + override def inputType: AbstractDataType = AnyDataType --- End diff -- why can't this be expressed? isn't the old ordered a way to express it?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org