GitHub user rxin opened a pull request:

    https://github.com/apache/spark/pull/15989

    [SPARK-18557] Downgrade confusing memory leak warning message

    ## What changes were proposed in this pull request?
    TaskMemoryManager has a memory leak detector that gets called at task 
completion callback and checks whether any memory has not been released. If 
they are not released by the time the callback is invoked, TaskMemoryManager 
releases them.
    
    The current error message says something like the following:
    ```
    WARN  [Executor task launch worker-0]
    org.apache.spark.memory.TaskMemoryManager - leak 16.3 MB memory from
    org.apache.spark.unsafe.map.BytesToBytesMap@33fb6a15
    In practice, there are multiple reasons why these can be triggered in the 
normal code path (e.g. limit, or task failures), and the fact that these 
messages are log means the "leak" is fixed by TaskMemoryManager.
    ```
    
    To not confuse users, this patch downgrade the message from warning to 
debug level, and avoids using the word "leak" since it is not actually a leak.
    
    ## How was this patch tested?
    N/A - this is a simple logging improvement.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rxin/spark SPARK-18557

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/15989.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15989
    
----
commit 46b5af977f5976101e1b325de0ff3ac081e65235
Author: Reynold Xin <r...@databricks.com>
Date:   2016-11-23T07:59:23Z

    [SPARK-18557] Downgrade confusing memory leak warning message

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to