Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/15984#discussion_r89312793
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
@@ -121,6 +123,12 @@ class HistoryServer(
def initialize() {
attachPage(new HistoryPage(this))
+ attachHandler(createRedirectHandler(
+ "/logs/delete",
+ "/",
+ handleDeleteLogRequest,
+ httpMethods = Set("GET", "POST")))
+
--- End diff --
it shouldn't be a GET for something side effecting; breaks the whole HTTP
"no side effects on a GET" rule. Better: support DELETE for high-rest; POST if
you want to support HTML <= 4.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
