Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15976#discussion_r89341912
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/ObjectHashAggregateSuite.scala
---
@@ -425,7 +417,35 @@ class ObjectHashAggregateSuite
}
}
- private def function(name: String, args: Column*): Column = {
- Column(UnresolvedFunction(FunctionIdentifier(name), args.map(_.expr),
isDistinct = false))
+ test("SPARK-18403 Fix unsafe data false sharing issue in
ObjectHashAggregateExec") {
+ // SPARK-18403: An unsafe data false sharing issue may trigger OOM /
SIGSEGV when evaluating
+ // certain aggregate functions. To reproduce this issue, the following
conditions must be
+ // met:
+ //
+ // 1. The aggregation must be evaluated using
`ObjectHashAggregateExec`;
+ // 2. There must be an input column whose data type involves
`ArrayType` or `MapType`;
+ // 3. Sort-based aggregation fallback must be triggered during
evaluation.
+ withSQLConf(
+ SQLConf.USE_OBJECT_HASH_AGG.key -> "true",
+ SQLConf.OBJECT_AGG_SORT_BASED_FALLBACK_THRESHOLD.key -> "1"
--- End diff --
not related to this PR, but the config name looks weird, how about
`OBJECT_AGG_FALLBACK_TO_SORT_THRESHOLD`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
