Github user steveloughran commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12004#discussion_r89346124
  
    --- Diff: 
cloud/src/test/scala/org/apache/spark/cloud/AzureInstantiationSuite.scala ---
    @@ -0,0 +1,29 @@
    +/*
    --- End diff --
    
    In the absence of any real tests, these do check that the transient stuff 
is picked up, and, at a surface level, there aren't fundamental differences 
between jackson versions.
    
    I have a copy of the same tests in my downstream integration tests, where 
they are the first stop for detecting problems, the advantage being you don't 
need any credentials to run the tests —and they validate the spark-cloud 
exports, rather than the spark-cloud test CP. I'll cut them from here if you 
want


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to