Github user colorant commented on a diff in the pull request:
https://github.com/apache/spark/pull/2240#discussion_r17032661
--- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
@@ -223,14 +226,14 @@ object SparkEnv extends Logging {
val shuffleMemoryManager = new ShuffleMemoryManager(conf)
+ val blockTransferService = new CMBlockTransferService(conf,
securityManager)
+
--- End diff --
Then, how did you plan to handle this securityManager parameter? move it
into BlockTransferService interface ( though some implementation might not need
it) to make it easy for instantiate works? or some how tweak connectionManager
to make it use SecurityManager in lazy way so that it can retrive it from
SparkEnv?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
