Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15960
I skimmed all the instances here, and only a handful look like they might
make a noticeable impact on performance. Almost all are tests, log messages,
exception messages. Still, might be a tiny win in here.
I am still tempted because we are able to enforce this with checkstyle and
it is a little ugly. (I'm especially amused by the `toString` that uses a
StringBuilder, but feeds it strings concatenated with "+", and uses
interpolation, but it isn't even needed!).
What if we did the work to back-port this to 2.0.x? that would
significantly reduce the back-porting conflict problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
