Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16009#discussion_r89671075
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala ---
    @@ -49,15 +49,13 @@ private[feature] trait ChiSqSelectorParams extends 
Params
        *
        * @group param
        */
    -  @Since("1.6.0")
    --- End diff --
    
    Usually we don't add ```since``` tag to variables and functions in traits, 
since they may be inherited by new child classes later on and the tag is 
incorrect for them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to