Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15961#discussion_r89671365
  
    --- Diff: python/pyspark/context.py ---
    @@ -373,8 +375,19 @@ def stop(self):
             Shut down the SparkContext.
             """
             if getattr(self, "_jsc", None):
    -            self._jsc.stop()
    -            self._jsc = None
    +            try:
    +                self._jsc.stop()
    +            except Py4JError:
    +                # Case: SPARK-18523
    +                warnings.warn(
    +                    'Unable to cleanly shutdown Spark JVM process.'
    +                    ' It is possible that the process has crashed'
    +                    ' or been killed, but may also be in a zombie state.',
    --- End diff --
    
    sgtm either way :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to