Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15913#discussion_r89673786
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -432,24 +418,26 @@ private[ml] trait GBTParams extends
TreeEnsembleParams with HasMaxIter with HasS
// final val validationTol: DoubleParam = new DoubleParam(this,
"validationTol", "")
// validationTol -> 1e-5
- setDefault(maxIter -> 20, stepSize -> 0.1)
-
/** @group setParam */
def setMaxIter(value: Int): this.type = set(maxIter, value)
/**
- * Step size (a.k.a. learning rate) in interval (0, 1] for shrinking the
contribution of each
- * estimator.
+ * Param for Step size (a.k.a. learning rate) in interval (0, 1] for
shrinking
+ * the contribution of each estimator.
* (default = 0.1)
- * @group setParam
+ * @group param
*/
+ final val stepSize: DoubleParam = new DoubleParam(this, "stepSize",
"Step size " +
+ "(a.k.a. learning rate) in interval (0, 1] for shrinking the
contribution of each estimator.",
+ ParamValidators.inRange(0, 1, lowerInclusive = false, upperInclusive =
true))
+
+ /** @group getParam */
+ final def getStepSize: Double = $(stepSize)
+
+ /** @group setParam */
def setStepSize(value: Double): this.type = set(stepSize, value)
--- End diff --
@jkbradley I have sent #16017 to fix this issue, please feel free to
comment that. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
