Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16013#discussion_r89676461
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
 ---
    @@ -57,9 +57,17 @@ import org.apache.spark.util.SerializableJobConf
      * @param partition a map from the partition key to the partition value 
(optional). If the partition
      *                  value is optional, dynamic partition insert will be 
performed.
      *                  As an example, `INSERT INTO tbl PARTITION (a=1, b=2) 
AS ...` would have
    - *                  Map('a' -> Some('1'), 'b' -> Some('2')),
    + *
    + *                  {{{
    + *                  Map('a' -> Some('1'), 'b' -> Some('2'))
    + *                  }}},
    + *
      *                  and `INSERT INTO tbl PARTITION (a=1, b) AS ...`
    - *                  would have Map('a' -> Some('1'), 'b' -> None).
    + *                  would have
    + *
    + *                  {{{
    + *                  Map('a' -> Some('1'), 'b' -> None)
    + *                  }}}.
    --- End diff --
    
    - Scala
      <img width="428" alt="2016-11-27 4 13 22" 
src="https://cloud.githubusercontent.com/assets/6477701/20642663/f024c068-b457-11e6-92f1-26f0b890c8f1.png";>
    
      <img width="457" alt="2016-11-27 4 13 29" 
src="https://cloud.githubusercontent.com/assets/6477701/20642662/ef11cbe4-b457-11e6-9556-a1221cf32c6a.png";>
    
    - Java
      <img width="535" alt="2016-11-27 4 13 10" 
src="https://cloud.githubusercontent.com/assets/6477701/20642666/f33733a8-b457-11e6-9844-dfcccea2144c.png";>
    
      <img width="523" alt="2016-11-27 4 13 12" 
src="https://cloud.githubusercontent.com/assets/6477701/20642665/f1e6ddbe-b457-11e6-8735-169d0cb42b97.png";>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to