Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15994#discussion_r89690706
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala ---
@@ -128,66 +128,49 @@ final class DataFrameNaFunctions private[sql](df:
DataFrame) {
}
/**
- * Returns a new [[DataFrame]] that replaces null or NaN values in
numeric columns with `value`.
+ * Returns a new [[DataFrame]] that replaces null or NaN values
+ * in numeric, boolean, string columns with `value`.
*
* @since 1.3.1
*/
- def fill(value: Double): DataFrame = fill(value, df.columns)
+ def fill[T](value: T): DataFrame = fill(value, df.columns)
--- End diff --
I think we can have a `private def fill[T]`, but the public API can't be
changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
