Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15954#discussion_r90086100
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamTest.scala ---
    @@ -669,55 +658,48 @@ trait StreamTest extends QueryTest with 
SharedSQLContext with Timeouts {
         }
       }
     
    -
    -  class QueryStatusCollector extends StreamingQueryListener {
    +  /** Collects events from the StreamingQueryListener for testing */
    +  class EventCollector extends StreamingQueryListener {
    --- End diff --
    
    I don't think this needs to be an inner class of `StreamTest`.  This file 
is pretty long/complicated as is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to