Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16072#discussion_r90158161
--- Diff: dev/create-release/release-build.sh ---
@@ -150,6 +150,7 @@ if [[ "$1" == "package" ]]; then
NAME=$1
FLAGS=$2
ZINC_PORT=$3
+ BUILD_PIP_PACKAGE=$4
--- End diff --
This style of positional boolean flag won't really work if you ever need to
have more than one of these arguments. That said, this is fine for now and if
we're really going to add any more complexity here then we should probably just
rewrite this whole script in Python.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
