Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16052#discussion_r90182581
  
    --- Diff: 
streaming/src/test/scala/org/apache/spark/streaming/StreamingContextSuite.scala 
---
    @@ -869,6 +891,31 @@ object TestReceiver {
       val counter = new AtomicInteger(1)
     }
     
    +class FakeByteArrayReceiver extends 
Receiver[Array[Byte]](StorageLevel.MEMORY_ONLY) with Logging {
    --- End diff --
    
    nit: Why create a new class? Is there any concern to just use TestReceiver?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to