Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15987
Hi, @hvanhovell , @gatorsmile , @rxin .
Should we remove *Expression* related stuff?
Originally, #15302 does not have this kind of expression issue. It's just
an extension of the current Spark.
But, while supporting expressions in partition spec, I made #15704 . but
it's reverted now. IMO, the followings can be different issues.
1. SUPPORT DROP BY FILTER (#15302)
2. SUPPORT EXPRESSION ON PARTITION SPEC
Especially, Apache Spark `Command` is not designed to carry expression, so
it seems to make things complex and weird like in this PR.
Also, for 2, we need to support expressions on ADD PARTITION, too. For
example, current Spark do the following, but Hive makes a partition `p=10`.
```
scala> sql("create table tbl_x (a int) partitioned by (p int)")
scala> sql("alter table tbl_x add partition (p=10.0)")
scala> sql("show partitions tbl_x").show
+---------+
|partition|
+---------+
| p=10.0|
+---------+
```
In short, this is beyond of 1, I think we had better go back the old
version (without expression.) How do you think about this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
