Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16080#discussion_r90362091
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -232,17 +233,26 @@ private[spark] class HiveExternalCatalog(conf:
SparkConf, hadoopConf: Configurat
}
private def createDataSourceTable(table: CatalogTable, ignoreIfExists:
Boolean): Unit = {
+ // data source table always have a provider, it's guaranteed by
`DDLUtils.isDatasourceTable`.
+ val provider = table.provider.get
+
// To work around some hive metastore issues, e.g. not
case-preserving, bad decimal type
// support, no column nullability, etc., we should do some extra works
before saving table
// metadata into Hive metastore:
- // 1. Put table metadata like provider, schema, etc. in table
properties.
+ // 1. Put table metadata like table schema, partition columns, etc.
in table properties.
// 2. Check if this table is hive compatible.
// 2.1 If it's not hive compatible, set location URI, schema,
partition columns and bucket
// spec to empty and save table metadata to Hive.
// 2.2 If it's hive compatible, set serde information in table
metadata and try to save
// it to Hive. If it fails, treat it as not hive compatible
and go back to 2.1
val tableProperties = tableMetaToTableProps(table)
+ // put table provider and partition provider in table properties.
+ tableProperties.put(DATASOURCE_PROVIDER, provider)
--- End diff --
Previously we store the provider in the code path for both data source and
hive serde tables. Now I move it to the data source table only code path.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
